feat(ourlogs): Add auto-refresh to logs #94887
Conversation
github-actions
bot
added
the
Scope: Frontend
This adds an auto-refresh toggle behind the 'ourlogs-live-refresh' flag. Auto-refresh can be enabled with filters so long as the sort is by time and descending. It works on 5 second polling, with a virtual time using RAF to emulate streaming. Filters are applied so data is queried in a ~30s second window behind our ingest delay. Auto-refresh will automatically disable itself under the following conditions: - You've hit a rate limit consistently over 3 polls (>1k logs/s) - You've hit an api error for any reason - You've hit the absolute timeout cap (10 minutes), you can re-enable it if you're actively using it - You change sort / filter etc.
k-fish
force-pushed
the
feat/ourlogs/auto-refresh-base
branch
from
eaeb4a4 to
cc21771
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Bug: Time Sort Check Fails for Descending Order
The checkSortIsTimeBasedDescending function incorrectly checks if any sort is descending, rather than verifying that the time-based sort (obtained from getTimeBasedSortBy) is specifically descending. This can lead to auto-refresh being enabled when the time-based sort is ascending, causing incorrect behavior.
static/app/views/explore/logs/utils.tsx#L198-L204
sentry/static/app/views/explore/logs/utils.tsx
Lines 198 to 204 in 5c1c48d
Was this report helpful? Give feedback by reacting with 👍 or 👎
| ); | ||
| }, [data]); | ||
|
|
||
| // We setup a RAF loop to update the virtual timestamp smoothly to emulate real-time streaming. |
There was a problem hiding this comment.
I wonder if we should have a throttled RAF if we detect bad hardware or older browsers somehow. Maybe do 30fps?
Would be nice to have some stats (send logs?) to track metrics on this.
|
|
||
| const refreshCallback = useRef(() => {}); // Since the interval fetches data, it's an infinite dependency loop. | ||
| const sortBysString = JSON.stringify(sortBys); |
There was a problem hiding this comment.
we should probably useMemo this.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
### Summary This adds an auto-refresh toggle behind the 'ourlogs-live-refresh' flag. Auto-refresh can be enabled with filters so long as the sort is by time and descending. It works on 5 second polling, with a virtual time using RAF to emulate streaming. Filters are applied so data is queried in a ~30s second window behind our ingest delay. Auto-refresh will automatically disable itself under the following conditions: - You've hit a rate limit consistently over 3 polls (>1k logs/s) - You've hit an api error for any reason - You've hit the absolute timeout cap (10 minutes), you can re-enable it if you're actively using it - You change sort / filter etc. A subsequent PR will contain changes for the graph updates. #### Other - Added some memos and callbacks for performance reasons since the virtual timestamp updates fairly quickly - Modified delayed data to follow already set delay in graphs (will be needed in the next PR)
Summary
This adds an auto-refresh toggle behind the 'ourlogs-live-refresh' flag.
Auto-refresh can be enabled with filters so long as the sort is by time and descending. It works on 5 second polling, with a virtual time using RAF to emulate streaming. Filters are applied so data is queried in a ~30s second window behind our ingest delay.
Auto-refresh will automatically disable itself under the following conditions:
A subsequent PR will contain changes for the graph updates.
Other